General refactoring and consolidation #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove `yarn.lock` files and keep `package-lock.json` in all samples - Remove ignore rule for `package-lock.json` files
nunojsferreira
requested changes
Dec 6, 2020
authentication/oauth-authorization-code/authorization-code-flow.js
Outdated
Show resolved
Hide resolved
inginheiiro
suggested changes
Dec 9, 2020
- client credentials sample: 11 packages removed - PAT sample: 3 packages removed - authorization code sample: 119 packages removed (!) - transaction sample: 4 packages removed
- Add main README file - Improve project names and descriptions - Improve sample projects' READMEs
Also rename the sample directories to a clear and more self-consistent naming scheme
Co-authored-by: Paulo Cabral <[email protected]>
…de sample This standardizes the code so that all the non-index files contain only methods that wrap calls to the Uphold API
This allows for cleaner failure when one of the API calls fails
The access token type in the authorization header must be "Bearer", with a capital B. This change also makes the code of the OAuth examples more consistent with that of the PAT example.
The /assets endpoint is accessible without authentication, so a call to it succeeds even with incorrect credentials, which defeats the purpose of using it to test the authentication flows. This commit switches it to a request to /me, which does require authentication (and as a bonus, is less verbose).
waldyrious
force-pushed
the
support/cleanup
branch
from
472ec19 to
cf9b2d9
Compare
nunojsferreira
approved these changes
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements various cleanup changes to consolidate and clean up the repository contents and structure after the initial seeding in #1, #2, #3 and #4. Namely, the following changes have been performed: