Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mcp-connector): add mcp-connector as composition #2

Merged
merged 2 commits into from
Aug 28, 2023

Conversation

haarchri
Copy link
Member

Description of your changes

  • add mcp-connector as composition

Fixes #

I have:

  • Read and followed Upbound's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested

image
KUBECONFIG=init/mcp.yaml kubectl get secrets aws-spoke-01-kubeconfig  -n default -o jsonpath="{.data.kubeconfig}" | base64 -d >>  init/kubeconfig-aws-spoke-01.yaml

KUBECONFIG=init/kubeconfig-aws-spoke-01.yaml kubectl api-resources | grep "upbound"
clusters                                       aws.caas.upbound.io/v1alpha1             true         Cluster
connectors                                     mcp.caas.upbound.io/v1alpha1             true         Connector
KUBECONFIG=init/kubeconfig-aws-spoke-01.yaml kubectl get pods -A | grep "mcp"
kube-system   mcp-connector-7bd57b9b49-4svnk             2/2     Running   0          23m

Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments.

It's already quite complex logic here, should we start to introduce uptest into the flow?

apis/upbound/mcp-connector/composition.yaml Show resolved Hide resolved
apis/upbound/mcp-connector/composition.yaml Show resolved Hide resolved
apis/upbound/mcp-connector/composition.yaml Outdated Show resolved Hide resolved
@haarchri
Copy link
Member Author

@ytsarev i will create a PR to introduce uptest for configuration-caas repo

Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haarchri haarchri merged commit 61b2d7c into upbound:main Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants