Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sourceMap: false is not being respected #42

Closed
5 tasks done
brc-dd opened this issue Dec 2, 2024 · 1 comment
Closed
5 tasks done

sourceMap: false is not being respected #42

brc-dd opened this issue Dec 2, 2024 · 1 comment
Labels

Comments

@brc-dd
Copy link

brc-dd commented Dec 2, 2024

Describe the bug

UnpluginIsolatedDecl({ transformer: 'oxc', sourceMap: false }) still emits index.d.ts.map

Might be an issue with oxc, typescript transformer works fine 👀

Reproduction

System Info

System:
    OS: macOS 15.1.1
    CPU: (8) arm64 Apple M1
    Memory: 388.44 MB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 22.11.0 - ~/.local/state/fnm_multishells/1482_1733160171083/bin/node
    Yarn: 1.22.22 - ~/.local/state/fnm_multishells/1482_1733160171083/bin/yarn
    npm: 10.9.0 - ~/.local/state/fnm_multishells/1482_1733160171083/bin/npm
    pnpm: 9.14.4 - ~/.local/state/fnm_multishells/1482_1733160171083/bin/pnpm
    bun: 1.1.38 - /opt/homebrew/bin/bun
  Browsers:
    Safari: 18.1.1

Used Package Manager

pnpm

Validations

  • Follow our Code of Conduct
  • Read the Contributing Guide.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
  • The provided reproduction is a minimal reproducible of the bug.
@sxzz
Copy link
Member

sxzz commented Dec 3, 2024

Looks like it's a bug in Oxc 🤔

@sxzz sxzz added the upstream label Dec 3, 2024
@sxzz sxzz closed this as completed in 24a935e Dec 3, 2024
Boshen added a commit to oxc-project/oxc that referenced this issue Dec 3, 2024
Don't pass `source_map_path` if `options.sourcemap` is undefined or
false; then, `IsolatedDeclarationsResult.map` should be undefined.

Downstream issue
unplugin/unplugin-isolated-decl#42

---------

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants