Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: icons generation frequency #328

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Conversation

ajpinedam
Copy link
Contributor

Fixes: #73

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@ajpinedam ajpinedam self-assigned this Feb 9, 2025
Copy link
Member

@jeromelaban jeromelaban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@ajpinedam ajpinedam force-pushed the dev/ajpm/fix.generate.assets.once branch from 8a4e6a8 to 2d490bd Compare February 10, 2025 21:24
@ajpinedam ajpinedam merged commit 7550619 into main Feb 10, 2025
15 checks passed
@ajpinedam ajpinedam deleted the dev/ajpm/fix.generate.assets.once branch February 10, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assets should be generated just once
2 participants