Merge pull request #284 from unoplatform/mergify/bp/release/stable/1.…

…4/pr-283 fix(incremental): Don't write files that have not changed (backport #283)
unoplatform · May 22, 2024 · d41e0ee · d41e0ee
2 parents 1211344 + 236162e
commit d41e0ee
Show file tree

Hide file tree

Showing 5 changed files with 76 additions and 20 deletions.
diff --git a/src/Resizetizer/src/CreatePartialInfoPlistTask.cs b/src/Resizetizer/src/CreatePartialInfoPlistTask.cs
@@ -34,18 +34,21 @@ public override bool Execute()
 
 				var plistFilename = Path.Combine(IntermediateOutputPath, PlistName ?? "PartialInfo.plist");
 
-				using (var f = File.CreateText(plistFilename))
-				{
-					f.WriteLine(plistHeader);
-
-					if (!string.IsNullOrEmpty(Storyboard))
+				FileHelper.WriteFileIfChanged(
+					plistFilename,
+					Log,
+					writer =>
 					{
-						f.WriteLine("  <key>UILaunchStoryboardName</key>");
-						f.WriteLine($"  <string>{Path.GetFileNameWithoutExtension(Storyboard)}</string>");
-					}
+						writer.WriteLine(plistHeader);
+
+						if (!string.IsNullOrEmpty(Storyboard))
+						{
+							writer.WriteLine("  <key>UILaunchStoryboardName</key>");
+							writer.WriteLine($"  <string>{Path.GetFileNameWithoutExtension(Storyboard)}</string>");
+						}
 
-					f.WriteLine(plistFooter);
-				}
+						writer.WriteLine(plistFooter);
+					});
 			}
 			catch (Exception ex)
 			{

diff --git a/src/Resizetizer/src/FileHelper.cs b/src/Resizetizer/src/FileHelper.cs
@@ -0,0 +1,46 @@
+using Microsoft.Build.Framework;
+using Microsoft.Build.Utilities;
+using System;
+using System.Collections.Generic;
+using System.IO;
+using System.Text;
+
+namespace Uno.Resizetizer
+{
+    internal class FileHelper
+    {
+        public static void WriteFileIfChanged(string fileName, TaskLoggingHelper log, Action<StreamWriter> action)
+        {
+            var tempFile = Path.GetTempFileName();
+            try
+            {
+                using (var writer = File.CreateText(tempFile))
+                {
+                    action(writer);
+                }
+
+                if (!File.Exists(fileName)
+                    || !File.ReadAllText(fileName).Equals(File.ReadAllText(tempFile)))
+                {
+                    File.Move(tempFile, fileName);
+                }
+                else
+                {
+                    log.LogMessage(MessageImportance.Low, $"Skipping unchanged {fileName}");
+                }
+
+            }
+            finally
+            {
+                try
+                {
+                    File.Delete(tempFile);
+                }
+                catch
+                {
+                    // ignore errors
+                }
+            }
+        }
+    }
+}
diff --git a/src/Resizetizer/src/GeneratePackageAppxManifest.cs b/src/Resizetizer/src/GeneratePackageAppxManifest.cs
@@ -65,11 +65,17 @@ public override bool Execute()
 					Log.LogWarning("Multiple AppxManifest files were provided. Only the first one will be used.");
 				}
 
-				var appx = XDocument.Load(AppxManifest[0].ItemSpec);
+				FileHelper.WriteFileIfChanged(
+					filename,
+					Log,
+					writer =>
+					{
+						var appx = XDocument.Load(AppxManifest[0].ItemSpec);
 
-				UpdateManifest(appx);
+						UpdateManifest(appx);
 
-				appx.Save(filename);
+						appx.Save(writer);
+					});
 
 				GeneratedAppxManifest = new TaskItem(filename);
 			}

diff --git a/src/Resizetizer/src/GenerateSplashStoryboard.cs b/src/Resizetizer/src/GenerateSplashStoryboard.cs
@@ -43,10 +43,10 @@ public override bool Execute()
 			var dir = Path.GetDirectoryName(OutputFile);
 			Directory.CreateDirectory(dir);
 
-			using (var writer = File.CreateText(OutputFile))
-			{
-				SubstituteStoryboard(writer, image, rStr, gStr, bStr, aStr);
-			}
+			FileHelper.WriteFileIfChanged(
+				OutputFile,
+				Log,
+				writer => SubstituteStoryboard(writer, image, rStr, gStr, bStr, aStr));
 
 			return !Log.HasLoggedErrors;
 		}

diff --git a/src/Resizetizer/src/GenerateWasmSplashAssets.cs b/src/Resizetizer/src/GenerateWasmSplashAssets.cs
@@ -63,9 +63,10 @@ public override bool Execute()
 		var dir = Path.GetDirectoryName(OutputFile);
 		Directory.CreateDirectory(dir);
 
-		using var writer = File.CreateText(OutputFile);
-
-		ProcessAppManifestFile(UserAppManifest.ToString(), info, writer);
+		FileHelper.WriteFileIfChanged(
+			OutputFile,
+			Log,
+			writer => ProcessAppManifestFile(UserAppManifest.ToString(), info, writer));
 
 		return true;
 	}