feat: Add a GitHub Actions workflow for use in CI workflows #339
+39
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jeromelaban
reviewed
Feb 18, 2025
Comment on lines
+40
to
+51
| - name: Install ${{ inputs.target-platform }} Workloads | ||
| shell: pwsh | ||
| run: | | ||
| dotnet tool install -g uno.check | ||
| ("${{ inputs.target-platform }} ".Split(' ') | ForEach-Object { | ||
| $target = $_.Replace("_win", "").Replace("_macos", "") | ||
| if (![string]::IsNullOrEmpty($target)) { | ||
| echo "target: $target" | ||
| uno-check -v --ci --non-interactive --fix --target $target --skip vswin --skip vsmac --skip xcode --skip vswinworkloads --skip androidemulator --skip dotnetnewunotemplates | ||
| echo "uno-check finished for target: $target " | ||
| } | ||
| }) |
There was a problem hiding this comment.
We probably could avoid running uno-check in a loop by adding multiple --target options instead.
There was a problem hiding this comment.
What do you mean?
This is the standard behaviour of the mini-workflow step included in the Uno platform template.
There was a problem hiding this comment.
Ah! That's right, then the other one probably should be changed as well, but that will do for now then.
jeromelaban
reviewed
Feb 18, 2025
Comment on lines
+40
to
+51
| - name: Install ${{ inputs.target-platform }} Workloads | ||
| shell: pwsh | ||
| run: | | ||
| dotnet tool install -g uno.check | ||
| ("${{ inputs.target-platform }} ".Split(' ') | ForEach-Object { | ||
| $target = $_.Replace("_win", "").Replace("_macos", "") | ||
| if (![string]::IsNullOrEmpty($target)) { | ||
| echo "target: $target" | ||
| uno-check -v --ci --non-interactive --fix --target $target --skip vswin --skip vsmac --skip xcode --skip vswinworkloads --skip androidemulator --skip dotnetnewunotemplates | ||
| echo "uno-check finished for target: $target " | ||
| } | ||
| }) |
There was a problem hiding this comment.
Ah! That's right, then the other one probably should be changed as well, but that will do for now then.
Co-authored-by: Jérôme Laban <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements an alternative way for consuming Uno.Check - from GitHub Actions.
This will appear in the GitHub Marketplace once a release on the repo is published or a tag is created.
This also removes the need for the massive unnecessary workflow files shipped with the Uno templates wizard downstream.