Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Lightweight Styling for Typography and Brushes #894

Merged
merged 5 commits into from
Dec 8, 2022
Merged

Enable Lightweight Styling for Typography and Brushes #894

merged 5 commits into from
Dec 8, 2022

Conversation

kazo0
Copy link
Collaborator

@kazo0 kazo0 commented Dec 3, 2022

#854

Treat Typography values, Brushes, and FontFamilies as ThemeResources

@kazo0 kazo0 force-pushed the dev/sb/font-overrides branch from a8e0695 to a844026 Compare December 3, 2022 19:36
@github-actions
Copy link

github-actions bot commented Dec 3, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-894.eastus2.azurestaticapps.net

2 similar comments
@github-actions
Copy link

github-actions bot commented Dec 3, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-894.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Dec 3, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-894.eastus2.azurestaticapps.net

@kazo0 kazo0 force-pushed the dev/sb/font-overrides branch from e645acd to 9b5ef64 Compare December 3, 2022 19:44
@github-actions
Copy link

github-actions bot commented Dec 3, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-894.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Dec 3, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-894.eastus2.azurestaticapps.net

@kazo0
feat!: Enable Lightweight Styling for Typography and Brushes
8b53f57 
BREAKING CHANGE: Removing Material-prefixed and control-specific Typography resource keys
@kazo0 kazo0 force-pushed the dev/sb/font-overrides branch from 8328d6b to 8b53f57 Compare December 3, 2022 20:57
@github-actions
Copy link

github-actions bot commented Dec 3, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-894.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Dec 3, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-894.eastus2.azurestaticapps.net

Xiaoy312
Xiaoy312 approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@Xiaoy312 Xiaoy312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should also create issues for updating toolkit, gallery, figma (expecially codegens)

@github-actions
Copy link

github-actions bot commented Dec 8, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-894.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Dec 8, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-894.eastus2.azurestaticapps.net

@kazo0 kazo0 enabled auto-merge (squash) December 8, 2022 20:53
@github-actions
Copy link

github-actions bot commented Dec 8, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-894.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Dec 8, 2022 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-894.eastus2.azurestaticapps.net

@kazo0 kazo0 merged commit 18fae91 into master Dec 8, 2022
@kazo0 kazo0 deleted the dev/sb/font-overrides branch December 8, 2022 21:58
@lesterbotello lesterbotello mentioned this pull request May 30, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xiaoy312 Xiaoy312 Xiaoy312 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kazo0 @Xiaoy312