-
-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(smart-contracts): replace revert strings by error codes #8867
Conversation
This reverts commit f4b330e.
It seems that Hardhat test runner is not catching the error messages properly - while
Hardhat should support custom errors, so maybe sth in passing around the errors defs |
Here is a repro repo to see where the problem is https://github.com/clemsos/custom-errors-repro |
/rebase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use a more explicit error name but then LG!
Co-authored-by: Julien Genestoux <[email protected]>
Co-authored-by: Julien Genestoux <[email protected]>
Description
Here we replace
require
statement by Solidity Custom Errors. This decrease contract size and also improve gas consumption.Issues
Fixes
Refs #8380
Checklist:
Release Note Draft Snippet