-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: trim root folder /
when calculating relative paths
#142
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (have to test locally for possible perf improvement tough)
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #142 +/- ##
=======================================
Coverage 99.41% 99.41%
=======================================
Files 4 4
Lines 340 342 +2
Branches 105 105
=======================================
+ Hits 338 340 +2
Misses 2 2 β View full report in Codecov by Sentry. |
All set π |
π Maybe we should fix this in time? cc @danielroe |
relative
method when pass root path/
when calculating relative paths
π Linked issue
resolves #126
β Type of change
π Description
The
split
method will generate redundant""
when pass a root pathpathe/src/path.ts
Lines 213 to 215 in 055f50a
π Checklist