fix: better options handling for public host #112
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
β Type of change
π Description
This PR improves the options handling for public hosts.
If
public
is not explicitly provided, we infer it in this order:hostname
is explicitly localhost ?false
hostname
is explicitly anyhost range ?true
--host
flag provided (any value)?true
(this is for CLI auto compatibility)true
false
Listhen also shows smart warnings if options are used wrongly together:
public
option tofalse
localhost
to avoid security implicationsNote: Tunnel is a separate concept from public. One might choose to listen on either localhost or local network exposed server and expose a (private by default) tunnel.
π Checklist