fix: try to resolve .ts files with .js extension from js files
#337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
reviewed
Nov 1, 2024
| // Try resolving .ts files with .js extension | ||
| if ( | ||
| TS_EXT_RE.test(ctx.filename) || | ||
| TS_EXT_RE.test(ctx.parentModule?.filename || "") |
There was a problem hiding this comment.
While tests might pass (and I immediately cannot recall why we needed this check) it might be a safer option to add new checks in addition to the current ones.
There was a problem hiding this comment.
Yeah just to make you aware of the situation. Pushed a minimal change/fix now.
pi0
changed the title
.ts files with .js extension from .js files
pi0
changed the title
.ts files with .js extension from .js files.ts files with .js extension from js files
webpro
force-pushed
the
fix/resolve-js-to-ts
branch
from
d8e814e to
7aba248
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #334
Interestingly, with this change tests still pass and the use case is fixed. The change covers a regular use case I think: id's ending with JS resolve to a file with TS extension. BUT I'm probably missing something here, so please verify.
Btw, what's your dev mode to set breakpoints in source code directly (without build, register etc), is it possible? I often do something like
tsx --inspect src/cli.tsbut didn't succeed to create something like this.