Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use smarter proxy for interopDefault #318

Merged
merged 4 commits into from
Oct 4, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: use smarter proxy for interopDefault
  • Loading branch information
pi0 committed Oct 4, 2024
commit 61613f3eb964dc5b8f5abe3e653e65672feaa998
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@
"changelogen": "^0.5.7",
"config": "^3.3.12",
"consola": "^3.2.3",
"defu": "^6.1.4",
"destr": "^2.0.3",
"escape-string-regexp": "^5.0.0",
"eslint": "^9.11.1",
Expand Down
3 changes: 3 additions & 0 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

77 changes: 42 additions & 35 deletions src/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -102,45 +102,52 @@ export function jitiInteropDefault(ctx: Context, mod: any) {
return ctx.opts.interopDefault ? interopDefault(mod) : mod;
}

// Source: https://github.com/unjs/mlly/blob/2348417d25522b98ed60ccc10eb030abb2f65744/src/cjs.ts#L59C1-L93C2
function interopDefault(
sourceModule: any,
opts: { preferNamespace?: boolean } = {},
): any {
if (!isObject(sourceModule) || !("default" in sourceModule)) {
return sourceModule;
function interopDefault(mod: any): any {
if (!mod || !("default" in mod)) {
return mod;
}
const defaultValue = sourceModule.default;
if (
defaultValue === undefined ||
defaultValue === null ||
!Object.isExtensible(defaultValue)
) {
return sourceModule;

const defaultExport = mod.default;
if (defaultExport === undefined || defaultExport === null) {
return mod;
}
const _defaultType = typeof defaultValue;
if (
_defaultType !== "object" &&
!(_defaultType === "function" && !opts.preferNamespace)
) {
return opts.preferNamespace ? sourceModule : defaultValue;

const defaultExportType = typeof defaultExport;
if (defaultExportType !== "object" && defaultExportType !== "function") {
return mod;
}
for (const key in sourceModule) {
try {
if (!(key in defaultValue)) {
Object.defineProperty(defaultValue, key, {
enumerable: key !== "default",
configurable: key !== "default",
get() {
return sourceModule[key];
},
});
}
} catch (error_) {
console.log(error_);
}

const modKeys = Object.getOwnPropertyNames(mod);
if (modKeys.length === 1) {
return defaultExport;
}
return defaultValue;

return new Proxy(mod, {
get(target, prop, receiver) {
if (prop === "__esModule") {
return true; // Bypass other interops
}
if (Reflect.has(target, prop)) {
return Reflect.get(target, prop, receiver);
}
let fallback =
prop === "default"
? defaultExport
: Reflect.get(defaultExport, prop, receiver);
if (typeof fallback === "function") {
fallback = fallback.bind(defaultExport);
}
return fallback;
},
apply(target, thisArg, args) {
if (typeof target === "function") {
return Reflect.apply(target, thisArg, args);
}
if (defaultExportType === "function") {
return Reflect.apply(defaultExport, thisArg, args);
}
},
});
}

export function normalizeWindowsImportId(id: string) {
Expand Down
9 changes: 6 additions & 3 deletions test/__snapshots__/fixtures.test.ts.snap
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,13 @@ exports[`fixtures > data-uri > stdout 1`] = `""`;

exports[`fixtures > deps > stdout 1`] = `
"npm:config: true
npm:defu {}
npm:destr true
npm:etag: true
npm:mime: true
npm:typescript: true
npm:moment-timezone true"
npm:moment-timezone true
npm:zod: true"
`;

exports[`fixtures > env > stdout 1`] = `
Expand All @@ -35,8 +38,8 @@ exports[`fixtures > error-runtime > stderr 1`] = `"test error"`;
exports[`fixtures > error-runtime > stdout 1`] = `""`;

exports[`fixtures > esm > stdout 1`] = `
"{ utilsLib: { utils: { default: 'default' }, version: '123' } }
{ utils: { default: 'default' } }
"{ utilsLib: { utils: { a: 'a', default: 'default' }, version: '123' } }
{ utils: { a: 'a', default: 'default' } }
{
file: '<cwd>/test.js',
dir: '<cwd>',
Expand Down
4 changes: 4 additions & 0 deletions test/fixtures/deps/defu.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
import defuDefault from "defu";
import { defu } from "defu";

console.log("npm:defu", defu({}) && defuDefault({}));
7 changes: 7 additions & 0 deletions test/fixtures/deps/destr.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
import { destr } from "destr";
import destrDefault from "destr";

console.log(
"npm:destr",
destr("true") === true && destrDefault("true") === true,
);
2 changes: 2 additions & 0 deletions test/fixtures/deps/index.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import "./config";
import "./consola";
import "./defu";
import "./destr";
import "./etag";
import "./mime";
import "./typescript";
Expand Down
Loading