New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: handle `data:` imports (non-native only) #299

Merged

pi0 merged 8 commits into unjs:main from bohjak:fix/data-uri-import

Sep 25, 2024

Contributor

bohjak commented Sep 21, 2024

Resolves #207

Explicitly check for data: scheme and use native import to handle it.


          fix: handle data uri with native require

2519ec7

pi0 reviewed

View reviewed changes

src/require.ts Outdated Show resolved Hide resolved

pi0 changed the title ~~fix: handle data uri with native require~~ feat: handle data: imports


          fix: throw descriptive error on cjs data import

775e856

pi0 reviewed

View reviewed changes

src/require.ts Outdated Show resolved Hide resolved


          Update src/require.ts

8e04ef6

pi0 reviewed

View reviewed changes

src/require.ts Outdated Show resolved Hide resolved


          Apply suggestions from code review

43f1d42

pi0 reviewed

View reviewed changes

src/require.ts Outdated Show resolved Hide resolved


          Update src/require.ts

a692c3e

pi0 reviewed

View reviewed changes

test/fixtures/data-uri/index.ts Outdated Show resolved Hide resolved

pi0 and others added 3 commits

September 23, 2024 12:04


          Update test/fixtures/data-uri/index.ts

813e8bb


          lint

75a4692


          fix: ignore fixture in unsupported scenarios

10299fc

Contributor Author

bohjak commented Sep 24, 2024

@pi0 I've added the data-uri fixture to the ignore lists for the native and bun tests. Breaks native, because it requires ESM. I haven't looked into how exactly bun imports work, but for some reason the require keyword works fine with data URLs, but import doesn't 🤷

pi0 changed the title ~~feat: handle data: imports~~ feat: handle data: imports (non-native only)

pi0 approved these changes

View reviewed changes

Member

pi0 left a comment

Thanks!

pi0 merged commit 68d5be0 into unjs:main

7 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet