feat(node, uws): automatically detect binary message type

package.json

@@ -100,7 +100,7 @@
     "listhen": "^1.7.2",
     "prettier": "^3.3.3",
     "typescript": "^5.5.4",
-    "uWebSockets.js": "github:uNetworking/uWebSockets.js#v20.33.0",
+    "uWebSockets.js": "github:uNetworking/uWebSockets.js#v20.44.0",
     "unbuild": "^2.0.0",
     "vitest": "^2.0.0",
     "wrangler": "^3.67.1",

playground/_index.html.ts

@@ -73,10 +73,11 @@ export default /* html */ `
         log("ws", "Connecting to", url, "...");
         ws = new WebSocket(url);
 
-        ws.addEventListener("message", (event) => {
-          const { user = "system", message = "" } = event.data.startsWith("{")
-            ? JSON.parse(event.data)
-            : { message: event.data };
+        ws.addEventListener("message", async (event) => {
+          const data = typeof event.data === "string" ? event.data : await event.data.text();
+          const { user = "system", message = "" } = data.startsWith("{")
+            ? JSON.parse(data)
+            : { message: data };
           log(
             user,
             typeof message === "string" ? message : JSON.stringify(message),

playground/_shared.ts

@@ -11,6 +11,7 @@ export function createDemo<T extends Adapter<any, any>>(
     open(peer) {
       console.log(`[ws] open ${peer}`);
       peer.send({ user: "server", message: `Welcome to the server ${peer}!` });
+      peer.send(new TextEncoder().encode("(binary message works!)"));
       peer.subscribe("chat");
       peer.publish("chat", { user: "server", message: `${peer} joined!` });
     },

src/_utils.ts

@@ -5,10 +5,20 @@ export function toBufferLike(val: any): BufferLike {
     return "";
   }
 
-  if (typeof val === "string") {
+  const type = typeof val;
+
+  if (type === "string") {
     return val;
   }
 
+  if (type === "number" || type === "boolean" || type === "bigint") {
+    return val.toString();
+  }
+
+  if (type === "function" || type === "symbol") {
+    return "{}";
+  }
+
   if (val instanceof Uint8Array || val instanceof ArrayBuffer) {
     return val;
   }

src/adapters/node.ts

@@ -145,21 +145,29 @@ class NodePeer extends Peer<{
     return this.ctx.node.ws.readyState;
   }
 
-  send(message: any, options?: { compress?: boolean; binary?: boolean }) {
-    this.ctx.node.ws.send(toBufferLike(message), {
+  send(message: any, options?: { compress?: boolean }) {
+    const data = toBufferLike(message);
+    const isBinary = typeof data !== "string";
+    this.ctx.node.ws.send(data, {
       compress: options?.compress,
-      binary: options?.binary,
+      binary: isBinary,
       ...options,
     });
     return 0;
   }
 
-  publish(topic: string, message: any): void {
-    message = toBufferLike(message);
+  publish(topic: string, message: any, options?: { compress?: boolean }): void {
+    const data = toBufferLike(message);
+    const isBinary = typeof data !== "string";
+    const sendOptions = {
+      compress: options?.compress,
+      binary: isBinary,
+      ...options,
+    };
     for (const client of this.ctx.node.server.clients) {
       const peer = (client as WebSocketT & { _peer?: NodePeer })._peer;
       if (peer && peer !== this && peer._subscriptions.has(topic)) {
-        peer.send(message);
+        peer.ctx.node.ws.send(data, sendOptions);
       }
     }
   }

src/adapters/uws.ts

@@ -174,24 +174,20 @@ class UWSPeer extends Peer<{
     return this._headers;
   }
 
-  send(message: any, options?: { compress?: boolean; binary?: boolean }) {
-    return this.ctx.uws.ws.send(
-      toBufferLike(message),
-      options?.binary,
-      options?.compress,
-    );
+  send(message: any, options?: { compress?: boolean }) {
+    const data = toBufferLike(message);
+    const isBinary = typeof data !== "string";
+    return this.ctx.uws.ws.send(data, isBinary, options?.compress);
   }
 
   subscribe(topic: string): void {
     this.ctx.uws.ws.subscribe(topic);
   }
 
-  publish(
-    topic: string,
-    message: string,
-    options?: { compress?: boolean; binary?: boolean },
-  ) {
-    this.ctx.uws.ws.publish(topic, message, options?.binary, options?.compress);
+  publish(topic: string, message: string, options?: { compress?: boolean }) {
+    const data = toBufferLike(message);
+    const isBinary = typeof data !== "string";
+    this.ctx.uws.ws.publish(topic, data, isBinary, options?.compress);
     return 0;
   }
 }