-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vim: support new ":def" functions of vim9 #2590
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2590 +/- ##
==========================================
- Coverage 86.67% 86.67% -0.01%
==========================================
Files 183 183
Lines 38608 38608
==========================================
- Hits 33464 33462 -2
- Misses 5144 5146 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you change the first line of the commit log to:
vim: support new ":def" functions of vim9
because we expect the first word of the commit log is names of parsers or names of subsystems.
We need a test case. Units/parser-vim.r is the directory for the vim parser. I need a test case for :def here.
See https://docs.ctags.io/en/latest/units.html . You can tests the vim parser with:
$ make units LANGUAGES=Vim
Added expected.tags.
@lacygoill, please look at 1a44f70 . A test case consists of two files: an input file and an expected output file. When adding code for |
Thank you for your contribution. I'm waiting for the patch for |
Thank you very much for merging the PR. |
This PR tries to add support for the new
:def
functions introduced in Vim9. See issue #2589 for more information.I briefly tested the patch, and it seems to work. That is now
ctags(1)
correctly generates tags for:def
functions.But I don't know if it's really correct; I don't know C.
If it is correct, I think I could also add support for constants defined with the
:const
keyword.