optlib2c: escape a double quote char in a description string w backslash #2022
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I'm interested in picking up the elixir branch (
elixir-optlib
) of this repo, and noticed that said branch has two commits: the first one, is this one I'm doing the pull request for, in which @masatake added the code to escape a double quote char in a string, and the second one, which has the code to parse elixir code.I noticed that the first commit isn't actually related to Elixir (or at least isn't in a way I could see), so it shouldn't be in the elixir branch, and it's useful enough to be merged into master. That's the reason I took this commit and rebased it to
master
, fixing a small conflict in the process. So now optlib should be able to parse the double quote char in a description string, and I should be free to hack onelixir-optlib
after rebasing it tomaster
.I'm not 100% sure how to test it, but what I did was
And it ran without any error I could notice.
Any help or thought related to the commit or how to test is well received.