Robot: remove empty expression .{0} in parsers/robots.c to fix unit test tmain and units on FreeBSD #1866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. I wondered who wrote the original line. Surprisingly, I wrote it. I should explain the background of the change in the commit log. However, "make units" on MacOSX on Travis says nothing wrong about your patch. I would like to merge your change. I have one request. Could you refer the above URLs (or commit ID) in your commit log? |
masatake
changed the title
Running unit tests tmain and units via 'make check' the empty expression
.{0} from the matching group in parsers/robot.c was causing FreeBSD libc
regcomp to produce an error: empty (sub)expression.
tmain would fail for some checks while units would fail for robots checks.
Removing the emptry expression .{0} "match anything exactly zero times"
fixes this issue and all expected tests pass for both tmain and units.
Testing the same change, removing the expression .{0} from the
matching group, on centos7 does not appear to have any regessions.
This reverts the following commit
universal-ctags@81a4593
That was created for the following issue:
universal-ctags#1571 (comment)
It's possible there's some regression for macOS however macOS on Travis
doesn't seem to have any issues.
derekschrock
force-pushed
the
empty-regex-expression
branch
from
8953a56 to
0e10675
Compare
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing empty expression .{0} fixes unit test on FreeBSD due to FreeBSD libc regcomp not liking the following (a|b|.{0}). Even though .{0} is valid removing it shouldn't create any issues.