Skip to content
This repository has been archived by the owner on May 26, 2021. It is now read-only.

Bug fix: TimeUnitQuantity.inverse() and TemporalQuantity.inverse() still returning time, not frequency #178

Closed
wants to merge 21 commits into from

Conversation

Pr0methean
Copy link
Contributor

#176 should be merged before this one.

HELP: Why are these simple changes causing the following, seemingly-unrelated, changes to fail?

[ERROR] Failures: 
[ERROR]   EBNFFormatTest.testParseInverseKg:80 expected:<[1/kg]> but was:<[one]>
[ERROR]   EBNFFormatTest.testParseInverseL:86 expected:<[1/l]> but was:<[one]>
[ERROR]   EBNFFormatTest.testParseInverseM:74 expected:<[1/m]> but was:<[one]>
[ERROR]   DecimalComparableQuantityTest.divideOperationsExceptionTest Expected exception: java.lang.ClassCastException
[ERROR]   DecimalComparableQuantityTest.multiplyOperationsExceptionTest Expected exception: java.lang.ClassCastException
[ERROR]   DoubleComparableQuantityTest.divideOperationsExceptionTest Expected exception: java.lang.ClassCastException
[ERROR]   DoubleComparableQuantityTest.multiplyOperationsExceptionTest Expected exception: java.lang.ClassCastException
[ERROR]   NumberComparableQuantityTest.divideOperationsExceptionTest Expected exception: java.lang.ClassCastException
[ERROR]   NumberComparableQuantityTest.multiplyOperationsExceptionTest Expected exception: java.lang.ClassCastException

…ot frequency units.

Refactors from Codacy

Automatic reformat

Partial commit

Unfinished commit to push for online diffing.

Partial commit to push for online diffing

Restore CRLF endings in the repo

Restore old CRLFs
Implement ProductElement.equals() and ProductElement.hashCode().
@keilw
Copy link
Member

keilw commented Aug 15, 2017

#176 was merged, but this has some conflicts with the master. Could you raise it again please based on the trunk, the codebase is stable and .gitconfig also has the desired effect now. Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants