Fix/ptl fixes #806
Merged
Fix/ptl fixes #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisbader
requested review from
hrzn,
tomasvanpottelbergh,
pennfranc and
brunnedu
as code owners
Codecov Report
@@ Coverage Diff @@
## master #806 +/- ##
==========================================
+ Coverage 91.04% 91.34% +0.29%
==========================================
Files 69 69
Lines 6858 6864 +6
==========================================
+ Hits 6244 6270 +26
+ Misses 614 594 -20
Continue to review full report at Codecov.
|
hrzn
approved these changes
Feb 17, 2022
| .. deprecated:: v0.17.0 | ||
| ``torch_device_str`` has been deprecated in v0.17.0 and will be removed in a future version. | ||
| Instead, specify this with keys ``"accelerator", "gpus", "auto_select_gpus"`` in your | ||
| ``pl_trainer_kwargs`` dict. For more info, see here: |
There was a problem hiding this comment.
Could you maybe write down which device will be used by default?
Also, you could maybe add a small example here. e.g. "use: gpus=-1 to use all available GPUs" or something along those lines. Or maybe using "auto"?
| @staticmethod | ||
| def _extract_torch_model_params(**kwargs): | ||
| @classmethod | ||
| def _validate_model_kwargs(cls, **kwargs): |
hrzn
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #802, #801
Summary
fixes:
adds: