Doc/data leak #2020
Merged
Doc/data leak #2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAttention: ❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
... and 5 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
dennisbader
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
Hi @SimTheGreat, I made some changes to your branch to fix the issue with the progress bars and the large git diffs.
Also made some other changes:
- improved the notebooks to load the models from the state with best performance on the validation set
- fixed some leftover issue with data transformers
- changed the way we call historical forecasts
As soon as tests pass, we can merge this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #644
Summary
darts.utils.callbacks.TFMProgressBarfor TorchForecastingModels to customize at which model states the progress bar should be displayed (sanity checks, training, validation, prediction).