-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/probabilistic ensemble #1692
Merged
Merged
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
406b4d0
feat: allow for probabilistic regression ensemble model by passing nu…
madtoinou b3a4d52
fix: propagating the new argument to the baseline
madtoinou a840eb5
Merge branch 'master' into feat/probabilistic_ensemble
madtoinou e3dbed5
feat: improved the definition of probabilistic EnsembleModel
madtoinou de5c096
doc: updating the docstring and quickstart to include information abo…
madtoinou b8ac4ae
doc: improved docstring for regression_model argument of RegressionEn…
madtoinou 0cc9b3b
feat: adding unittests
madtoinou b0d46b2
fix: updated EnsembleModel unittest that were covering RegressionEnse…
madtoinou e61c89f
feat: added 2 new parameters to control training of regression model …
madtoinou 0116f83
feat: simplify the ensembling method of NaiveEnsemble
madtoinou 36fd3a9
doc: changed phrasing of the note about how to make EnsembleModel pro…
madtoinou f085dbd
feat: improved the tests for stochastic naive ensemble
madtoinou 396d852
doc: added comments in regression ensemble tests, fixed a small typo …
madtoinou 6a16737
fix: bug in samples reduction prior to regression model training
madtoinou 2ed3928
feat: improving the tests for regression ensemble model
madtoinou d9b0121
fix: simplifiying tests synthax
madtoinou d5f0a39
Update CHANGELOG.md
madtoinou c4a27ae
fix: removed useless if else
madtoinou cb43cf8
Merge branch 'feat/probabilistic_ensemble' of https://github.com/unit…
madtoinou 53ed564
Merge branch 'master' into feat/probabilistic_ensemble
madtoinou 5238632
feat: possible to not reduce the prediction for RegressionEnsembleMod…
madtoinou 5baa581
Merge branch 'master' into feat/probabilistic_ensemble
madtoinou 09e0087
Merge branch 'master' into feat/probabilistic_ensemble
madtoinou 5bceba8
Apply suggestions from code review
madtoinou 69a7455
fix: adressing reviewer comments
madtoinou f565778
fix: ensemble with probabilistic forecasting models but deterministic…
madtoinou 3beee65
fix: moving predict back to base ensemble class, removed horizontal s…
madtoinou f07f416
Merge branch 'master' into feat/probabilistic_ensemble
madtoinou 02dab52
Apply suggestions from code review
madtoinou 23e399a
fix: addressing reviewer comments
madtoinou cc71a6d
merged with master
madtoinou d0dd636
fix: mixed (proba and deter) forecasting models sampling for regresso…
madtoinou File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is true for naive ensemble but not for RegressionEnsembleModel, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, the docstring is different in
RegressionEnsembleModel
. This note could probably be removed sinceEnsembleModel
cannot be instantiated anyway.