Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes lgb warning when not using any categorical features #1681

Merged
merged 6 commits into from
Apr 7, 2023
Merged

fixes lgb warning when not using any categorical features #1681

merged 6 commits into from
Apr 7, 2023

Conversation

dennisbader
Copy link
Collaborator

@dennisbader dennisbader commented Mar 31, 2023 •
edited
Loading

Summary

@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.09 ⚠️

Comparison is base (69e83dc) 94.14% compared to head (33f32ad) 94.05%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1681      +/-   ##
==========================================
- Coverage   94.14%   94.05%   -0.09%     
==========================================
  Files         125      125              
  Lines       11385    11371      -14     
==========================================
- Hits        10718    10695      -23     
- Misses        667      676       +9
Impacted Files Coverage Δ
darts/models/forecasting/regression_model.py 97.12% <100.00%> (+<0.01%) ⬆️
darts/utils/multioutput.py 81.48% <100.00%> (-0.67%) ⬇️

... and 9 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

madtoinou
madtoinou approved these changes Apr 6, 2023
View reviewed changes
Copy link
Collaborator

@madtoinou madtoinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed a small typo, a big concerned that the new Parallel import will break depending on the Python version but the merge github action will tell us if it does.

darts/utils/multioutput.py
from sklearn.utils.multiclass import check_classification_targets
from sklearn.utils.parallel import Parallel, delayed
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope that it does not break with python 3.7 which support is being dropped left and right... On scikit-learn github repository, they indicate "scikit-learn 1.0 and later require Python 3.7 or newer. scikit-learn 1.1 and later require Python 3.8 or newer.". Could not find in the log when did the parallel module change...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that's true, let's check later on in merge workflow.

@dennisbader dennisbader merged commit 21c185d into master Apr 7, 2023
@dennisbader dennisbader deleted the fix/lgbm_cat_warning branch April 7, 2023 14:23
@dennisbader dennisbader mentioned this pull request Apr 7, 2023
Merged
alexcolpitts96 pushed a commit to alexcolpitts96/darts that referenced this pull request May 31, 2023
@dennisbader @madtoinou @alexcolpitts96
fixes lgb warning when not using any categorical features (unit8co#1681)
b67976c 
* fixes lgb warning when not using any categorical features

* fixes deprecation warning for sklearn Parallel delayed

* fix failing unittest for categorical lgbm

* Apply suggestions from code review

Co-authored-by: madtoinou <[email protected]>

---------

Co-authored-by: madtoinou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madtoinou madtoinou madtoinou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dennisbader @codecov-commenter @madtoinou