Fix/Failing test - make TimeSeries.with_hierarchy type hint python 3.7 compatible #1656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #1656 +/- ##
==========================================
- Coverage 94.07% 94.06% -0.01%
==========================================
Files 125 125
Lines 11351 11338 -13
==========================================
- Hits 10678 10665 -13
Misses 673 673
... and 5 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
dennisbader
approved these changes
Mar 21, 2023
|
There was an error in the merge workflow due to Codecov not uploading, this is an issue unrelated to this PR |
alexcolpitts96
pushed a commit
to alexcolpitts96/darts
that referenced
this pull request
May 31, 2023
Co-authored-by: David Kleindienst <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the type hint introduced in #1592 to make it compatible with python 3.7.
Should fix the failing test on master