-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/ensemble historical forecasts #1616
Merged
dennisbader
merged 22 commits into
unit8co:master
from
JanFidor:fix/ensemble-historical-forecasts
Apr 10, 2023
Merged
Changes from 9 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
84973a3
add correct extreme_lags override and test
JanFidor 3c252d9
add required extreme_lags override
JanFidor 743c6ae
Merge branch 'master' into fix/ensemble-historical-forecasts
JanFidor eb92f9c
delete logging print
JanFidor b92971a
Merge branch 'fix/ensemble-historical-forecasts' of https://github.co…
JanFidor a5d80c7
Merge branch 'master' into fix/ensemble-historical-forecasts
madtoinou 5cc2571
Merge branch 'master' into fix/ensemble-historical-forecasts
JanFidor c56f9d1
Merge branch 'master' into fix/ensemble-historical-forecasts
dennisbader 3a9c4c7
Merge branch 'master' into fix/ensemble-historical-forecasts
madtoinou 847c0d6
change lag priorities
JanFidor e86bca3
Merge branch 'master' into fix/ensemble-historical-forecasts
JanFidor 028ecc8
Merge branch 'master' into fix/ensemble-historical-forecasts
dennisbader 1a9e7ed
add a test + use switch to tuple
JanFidor 14cba78
Merge branch 'fix/ensemble-historical-forecasts' of https://github.co…
JanFidor d84ca9a
Merge branch 'master' into fix/ensemble-historical-forecasts
JanFidor 0300d84
Merge branch 'master' into fix/ensemble-historical-forecasts
dennisbader c67ff16
Merge branch 'master' into fix/ensemble-historical-forecasts
dennisbader 200ebc6
fix extreme lags from other PR
dennisbader 8411bed
Merge branch 'master' into fix/ensemble-historical-forecasts
dennisbader d58b1b1
make RegressionEnsembleModel work
dennisbader b30206f
Merge branch 'master' into fix/ensemble-historical-forecasts
dennisbader b958132
small unit test fix
dennisbader File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this respects the actual min/max of all extreme lags.
For example lags_future_covariates for one regression models could be [-3, -2], and for a second one [-1, 1].
The min lag for both models should be -3, and max lag +1.
However, the current implementation would give min/max lags of -3 and -2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I assumed that for a given lag all values must either be positive or negative, and abs() would be working then. I checked out the docs and I think that the new implementation fixes the problem