-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new datasets to darts.dataset #1298
Conversation
Codecov ReportBase: 93.84% // Head: 93.83% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1298 +/- ##
==========================================
- Coverage 93.84% 93.83% -0.01%
==========================================
Files 78 78
Lines 8500 8488 -12
==========================================
- Hits 7977 7965 -12
Misses 523 523
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@FEJTWOW Thanks for adding a new dataset. I know many other repos have used this dataset for benchmarking. I believe Autoformer started using it. Are the time ranges the same? And if there not, can we add an arg to match it? |
@gdevos010 Can you specify what do you mean by time ranges. Do you want to specify the start date and end date or do you want to have an arg to specify the day of the week? For instance right now I've assumed that the data was updated every week on Sunday at 00:00:00, but it is possible to change the day while parsing. I've checked this dataset and their data covers time from 2002-01-01 to 2020-06-30. The dataset that I've just added covers data from 1997-10-12 to 2022-10-09. If you want to change your start day you can always do TimeSeries.drop_before() |
* Add new dataset to dataset catalog * Specify the class in darts.datasets.__init__.py to correctly load new dataset
13bc38d
to
f84b344
Compare
I think it'd be overkill to add supporting time ranges here, as IMO it would mix concerns quite a bit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @FEJTWOW ! I've added a few comments.
Regarding the traffic CSV file: it's quite big (100 MB). Could you check whether it could be better to use git large files for this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work @FEJTWOW
Fixes #617.
Summary