-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/gradle #112
Feat/gradle #112
Conversation
I will update readme with how we can use gradle etc, but will wait with that until changes to readme structure. |
} | ||
} | ||
|
||
dockerRun { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this works then probably clutter like run_docker.sh can be removed from repo (alsoe README should be updated)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scripts directory removed + readme updated.
- name: "6. Run linter" | ||
run: | | ||
flake8 --config=setup.cfg darts | ||
./gradlew test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might still need the step to eg. attach the cache for pip, probably not a gradle thing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, sorry I went into berserk delete everything mode.
@@ -104,39 +56,10 @@ jobs: | |||
with: | |||
python-version: 3.6 | |||
|
|||
- name: "3. Update pip and install pandoc" | |||
- name: "3. Install pandoc" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same remark - might still need to mount pip cache
build.gradle
Outdated
commandLine "python", "-m", "pip", "install", "--upgrade", "pip" | ||
} | ||
|
||
void pipInstallSteps() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how can we pick some of those steps? some build tasks need main + release, some need main + dev so installing all of those is not needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that form we couldn't but now it is splitted into 3 task and in other places tasks now depend only on needed requirements.
// Documentation build | ||
void docSteps() { | ||
exec { | ||
commandLine "make", "--directory", "./docs", "copy-examples" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there any gradle plugin for Makefile?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick googling didn't revealed any trustworthy looking plugins and to be honest I feel like plugin for Makefile would be an overkill.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed
@Kostiiii new README is out so feel free to take a shot at it :) |
@TheMP I think I extended README from develop branch already, did you see it? Do you want it to have some section I didn't include or to elaborate on something with more details? |
First step of introducing gradle to project.
Define tasks to build documentations, docker image, to run tests and some 'helpers' for installing requirements or project locally.