Feat/encoders extension #1093
Merged
Feat/encoders extension #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisbader
requested review from
hrzn,
tomasvanpottelbergh and
brunnedu
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1093 +/- ##
==========================================
+ Coverage 93.71% 93.72% +0.01%
==========================================
Files 80 80
Lines 8236 8250 +14
==========================================
+ Hits 7718 7732 +14
Misses 518 518
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
hrzn
approved these changes
Aug 8, 2022
| @@ -59,14 +51,10 @@ | |||
| (FFT(trend="poly"), 11.4), | |||
| (NaiveSeasonal(), 32.4), | |||
| (KalmanForecaster(dim_x=3), 17.0), | |||
| (LinearRegressionModel(lags=12), 11.0), | |||
| (RandomForest(lags=12, n_estimators=200, max_depth=3), 15.5), | |||
There was a problem hiding this comment.
Isn't n_estimators=200 a bit too much for a unit test? This doesn't take too long?
There was a problem hiding this comment.
I just took this from a few lines below, tbh. I can reduce it.
| @@ -361,6 +423,15 @@ def fit( | |||
| **kwargs | |||
| Additional keyword arguments passed to the `fit` method of the model. | |||
| """ | |||
|
|
|||
| self.encoders = self.initialize_encoders() | |||
| if self.encoders.encoding_available: | |||
|
|
||
| logger = get_logger(__name__) | ||
|
|
||
| try: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #693.
Summary
add_encoders(as already available for TorchForecastingModels)