-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add_seasonality does not expose the condition_name parameter for the prophet model #1049
Comments
Thanks for this suggestion. Would you be willing to make a contribution in this direction? |
More than happy! However, there are a few things that would need to change, and perhaps if you could suggest a direction. So another thing in the code that is an issue is:
Do you think we should add these extra columns as covariates? The reason I am hesitating is that some of these condition columns are not necessarily covariates. Currently, I am hacking it as:
but perhaps this is not ideal? The |
…_seasonality (#1829) * Fix #1049 - add prior_scale and mode arguments to prophet model's add_seasonality * Add option to treat seasonality as conditional * Add seasonality conditions with a condition_name and future_covariates * Add test for custom conditional seasonality * Add entry for pr #1829 * Update darts/models/forecasting/prophet_model.py Co-authored-by: Dennis Bader <[email protected]> * Update darts/models/forecasting/prophet_model.py Co-authored-by: Dennis Bader <[email protected]> * Validate seasonality considitions through a private method when calling fit() and predict() * Reduce predict horizon to 7. Add tests for missing and invalid conditions * Move entry to models improvements section * Update err msg in _check_seasonality_conditions Co-authored-by: Dennis Bader <[email protected]> * Import raise_log. Initialize formatted str when necessary. * Accept float seasonalities as well. Update test * Fix dtype of seasonal_periods. Update docstrings. * update docstring --------- Co-authored-by: Idan Shilon <[email protected]> Co-authored-by: Dennis Bader <[email protected]>
Is your feature request related to a current problem? Please describe.
The FB prophet add_seasonality method has a
condition_name
input variable that is not exposed by darts. This severely limits how custom seasonalities can be added.Describe proposed solution
The
add_seasonality
method inProphet
class should also take thecondition_name
as a parameter.Additionally, the current method which adds the serasonality also ignores the
prior_scale
andmode
parameters.The text was updated successfully, but these errors were encountered: