-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eg bootstrap update #123
Merged
Merged
Eg bootstrap update #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Resolved handling boostrap version passed in via bootstrap.
…n to bootstrap model that is used to determin if its an bootstrap update that is happening. Using this boolean to force an bootstrap update on exit click if its avilable.
…ns the temp folder.
timnhanta
pushed a commit
that referenced
this pull request
Oct 4, 2022
* Bootstrap: pass proj.ver to javafx. * bootstrap: set version to match fx * MS: added remove temp file when a new one has been found ! * updater: fixed issues with fx not starting based on older bootstraps. Resolved handling boostrap version passed in via bootstrap. * MS: Change launcher update message to make it clearer. added a boolean to bootstrap model that is used to determin if its an bootstrap update that is happening. Using this boolean to force an bootstrap update on exit click if its avilable. * added a download URL to test bootstrap update. * force windows app to close once the bootstrap installer opens * close app on exec and dont wait for it * catch explorer blocking users IP address * disable FXTrayIcon from pom for now as bootstrap needs swing for this to work * MS: added a dialog that tells the user when the install faild and opens the temp folder. Co-authored-by: Fim-84 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.