Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use ZeroMap2d for metazones #5746

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Conversation

robertbastian
Copy link
Member

@robertbastian robertbastian commented Oct 30, 2024

This could be even smaller if we had one map for standard names, and one for daylight names. #5745

Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know why this increases loc even though it decreases postcard? I imagine there's some reduplication happening in baked?

@robertbastian
Copy link
Member Author

Baked data LOC is the same, and the actually in-binary size decreases, as can be seen in fingerprints.csv. JSON gets more verbose because of tuples.

@Manishearth
Copy link
Member

oh, it's json size, okay. nice.

@robertbastian robertbastian merged commit a763d9f into unicode-org:main Oct 30, 2024
28 checks passed
@robertbastian robertbastian deleted the mz branch October 30, 2024 16:08
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants