Model BidiAuxiliaryProperties as an EnumeratedProperty
#5597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbastian
requested review from
sffc,
Manishearth,
hsivonen and
a team
as code owners
robertbastian
requested review from
younies
and removed request for
hsivonen and
echeran
younies
previously approved these changes
Sep 25, 2024
Manishearth
previously approved these changes
Sep 30, 2024
| } | ||
| fn from_unaligned(unaligned: Self::ULE) -> Self { | ||
| let [a, b, c] = unaligned.0; | ||
| TrieValue::try_from_u32(u32::from_le_bytes([a, b, c, 0])).unwrap_or_default() |
There was a problem hiding this comment.
hm. a non-safety invariant of ZeroVec is that byte equality is equality, are we okay with giving that up here?
The worst that can happen is that == on ZeroVec will do unexpected things with bad data, but I'm overall fine with that. Either way, I think we should document that this breaks the invariant but is convenient
cc @sffc
There was a problem hiding this comment.
Why do you think this is being given up here?
There was a problem hiding this comment.
The unwrap_or_default() means that two unequal byte sequences will produce equal values
There was a problem hiding this comment.
Ah right. I can write a custom ULE type?
Manishearth
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.