Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DurationFormatter: Implement DurationFormatter #5321

Merged
merged 13 commits into from
Aug 13, 2024
Merged

DurationFormatter: Implement DurationFormatter #5321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
089de2f
add separate hms, hm and ms padding structs
kartva Jul 21, 2024
c26347d
numeric formatting functions
kartva Jul 23, 2024
b66b7d9
add fractional truncation to format numeric second
kartva Jul 28, 2024
9dc37bb
add divergence note for twoDigitHours
kartva Jul 29, 2024
c959236
DurationFormatter constructor and digital test
kartva Jul 29, 2024
6cb98f9
fix fractionaldigit truncation
kartva Jul 29, 2024
447ceec
fmt
kartva Jul 29, 2024
810a2a5
add listformat
kartva Jul 31, 2024
cb5ab0c
Merge branch 'main' into duration-formatter-impl
kartva Jul 31, 2024
74e038a
DurationSign->fixedDecimal::Sign map Positive to None sign
kartva Jul 31, 2024
edce2ae
fix: incorrect hour digital default
kartva Aug 1, 2024
5b4e69f
add durationformatter tests
kartva Aug 1, 2024
ba27195
add compiled_data annotation to DurationUnitFormatter::try_new
kartva Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions components/experimental/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ icu_provider = { workspace = true, features = ["macros"] }
icu_locale_core = { workspace = true }

icu_decimal = { workspace = true }
icu_list = { workspace = true }
icu_locale = { workspace = true }
icu_normalizer = { workspace = true }
icu_plurals = { workspace = true }
Expand Down Expand Up @@ -66,10 +67,10 @@ icu_normalizer_data = { workspace = true }

[features]
default = ["compiled_data"]
compiled_data = ["dep:icu_experimental_data", "icu_decimal/compiled_data", "icu_plurals/compiled_data", "icu_properties/compiled_data", "icu_normalizer/compiled_data"]
compiled_data = ["dep:icu_experimental_data", "icu_decimal/compiled_data", "icu_list/compiled_data", "icu_plurals/compiled_data", "icu_properties/compiled_data", "icu_normalizer/compiled_data"]
datagen = ["serde", "std", "dep:databake", "zerovec/databake", "zerotrie/databake", "tinystr/databake", "icu_collections/databake", "std", "log", "icu_pattern/databake"]
ryu = ["fixed_decimal/ryu"]
serde = ["dep:serde", "zerovec/serde", "tinystr/serde", "icu_collections/serde", "icu_decimal/serde", "icu_pattern/serde", "icu_plurals/serde", "icu_provider/serde", "zerotrie/serde"]
serde = ["dep:serde", "zerovec/serde", "tinystr/serde", "icu_collections/serde", "icu_decimal/serde", "icu_list/serde", "icu_pattern/serde", "icu_plurals/serde", "icu_provider/serde", "zerotrie/serde"]
std = ["fixed_decimal/std", "icu_decimal/std", "icu_pattern/std", "icu_plurals/std", "icu_provider/std", "icu_locale_core/std"]

bench = []
Expand Down
10 changes: 5 additions & 5 deletions components/experimental/src/duration/duration.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ impl Duration {
}

/// Describes whether a [`Duration`] is positive or negative.
#[derive(Debug, Default, Clone, PartialEq, Eq, PartialOrd, Ord)]
#[derive(Debug, Default, Clone, Copy, PartialEq, Eq, PartialOrd, Ord)]
pub enum DurationSign {
#[default]
/// A positive duration.
Expand All @@ -72,10 +72,10 @@ pub enum DurationSign {
Negative,
}

impl DurationSign {
pub(crate) fn as_fixed_decimal_sign(&self) -> fixed_decimal::Sign {
match self {
DurationSign::Positive => fixed_decimal::Sign::Positive,
impl From<DurationSign> for fixed_decimal::Sign {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 that is good too.

fn from(sign: DurationSign) -> Self {
match sign {
DurationSign::Positive => fixed_decimal::Sign::None,
DurationSign::Negative => fixed_decimal::Sign::Negative,
}
}
Expand Down
Loading