Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DryDataProvider for baked providers #5211

Merged
merged 6 commits into from
Aug 19, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions provider/baked/src/export.rs
Original file line number Diff line number Diff line change
Expand Up @@ -658,6 +658,13 @@ impl DataExporter for BakedExporter {
pub(crate) const MUST_USE_MAKE_PROVIDER_MACRO: () = ();
}
icu_provider::marker::impl_data_provider_never_marker!($name);
impl<M: icu_provider::DataMarker> icu_provider::DryDataProvider<M> for $name
where $name: icu_provider::DataProvider<M>
{
fn dry_load(&self, req: icu_provider::DataRequest) -> Result<icu_provider::DataResponseMetadata, icu_provider::DataError> {
icu_provider::DataProvider::load(self, req).map(|r| r.metadata)
}
}
};
}
#[doc(inline)]
Expand Down
8 changes: 8 additions & 0 deletions provider/baked/tests/data/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,14 @@ macro_rules! __make_provider {
pub(crate) const MUST_USE_MAKE_PROVIDER_MACRO: () = ();
}
icu_provider::marker::impl_data_provider_never_marker!($name);
impl<M: icu_provider::DataMarker> icu_provider::DryDataProvider<M> for $name
where
$name: icu_provider::DataProvider<M>,
{
fn dry_load(&self, req: icu_provider::DataRequest) -> Result<icu_provider::DataResponseMetadata, icu_provider::DataError> {
icu_provider::DataProvider::load(self, req).map(|r| r.metadata)
}
}
};
}
#[doc(inline)]
Expand Down
17 changes: 13 additions & 4 deletions provider/baked/tests/test-baked-source.rs
Original file line number Diff line number Diff line change
Expand Up @@ -27,16 +27,25 @@ fn iter() {

#[test]
fn load() {
use icu_provider::hello_world::HelloWorldProvider;
use icu_provider::hello_world::{HelloWorldProvider, HelloWorldV1Marker};
use icu_provider::prelude::*;

for id in HelloWorldProvider.iter_ids().unwrap().iter() {
for id in HelloWorldProvider
.iter_ids()
.unwrap()
.into_iter()
.chain([DataIdentifierCow::default()])
{
let req = DataRequest {
id: id.as_borrowed(),
..Default::default()
};
let expected = HelloWorldProvider.load(req).unwrap().payload;
let baked = Baked.load(req).unwrap().payload;
let expected = HelloWorldProvider.load(req);
let baked = DataProvider::load(&Baked, req);
assert_eq!(baked.map(|r| r.payload), expected.map(|r| r.payload));

let expected = HelloWorldProvider.dry_load(req);
let baked = DryDataProvider::<HelloWorldV1Marker>::dry_load(&Baked, req);
assert_eq!(baked, expected);
}
}
8 changes: 8 additions & 0 deletions provider/data/calendar/data/mod.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions provider/data/calendar/stubdata/mod.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions provider/data/casemap/data/mod.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions provider/data/casemap/stubdata/mod.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions provider/data/collator/data/mod.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions provider/data/collator/stubdata/mod.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions provider/data/datetime/data/mod.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions provider/data/datetime/stubdata/mod.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions provider/data/decimal/data/mod.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions provider/data/decimal/stubdata/mod.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions provider/data/experimental/data/mod.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions provider/data/experimental/stubdata/mod.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions provider/data/list/data/mod.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions provider/data/list/stubdata/mod.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions provider/data/locale/data/mod.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions provider/data/locale/stubdata/mod.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions provider/data/normalizer/data/mod.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions provider/data/normalizer/stubdata/mod.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions provider/data/plurals/data/mod.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions provider/data/plurals/stubdata/mod.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions provider/data/properties/data/mod.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions provider/data/properties/stubdata/mod.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading