-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move internal fallback option to baked exporter options #5036
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except please change DeduplicationStrategy back to depending on the exporter. I suggest changing the trait function supports_built_in_fallback
to instead be default_deduplication_strategy
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
The current architecture raises the question: Are |
We've gone in circles so many times that I think making things "excessively non-exhaustive" is the right path. It would be reasonable though to have the following functions:
|
Different PR anyway |
I also changed the
DeduplicationStrategy
to default toRetainBaseLanguages
, instead of being inferred bysupports_builtin_fallback
. I haven't change testdata/bakedata generation, as I don't want a data diff in this PR.