Datagen: Add new decimal pattern used in Toki Pona (tok) in CLDR 44
#4156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
changed the title
tok)tok) in CLDR 44
sffc
requested review from
srl295 and
echeran
and removed request for
Manishearth and
robertbastian
Manishearth
approved these changes
Oct 14, 2023
echeran
approved these changes
Oct 15, 2023
|
Are there other patterns we can add now to be more future compatible? |
|
Why is there even a list, as the TODO suggests? Is it just to avoid a parser? |
|
A parser could be written, but I actually kind-of like the clarity of the explicit list. But if someone wants to write a parser, it's one of our oldest good first issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4155
First locale to use something other than 3 as the primary grouping size.