Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit magnitudes of From<FixedDecimal> for PluralOperands to prevent overflow #293

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Limit magnitudes of From<FixedDecimal> for PluralOperands to prevent overflow #293

merged 1 commit into from
Oct 6, 2020

Conversation

sffc
Copy link
Member

@sffc sffc commented Oct 3, 2020

Fixes #290

@sffc sffc requested review from filmil and zbraniecki October 3, 2020 05:20
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4f0297acd4fd97658f32a78aa47fd08585db4415-PR-293

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 77.161%
Totals Coverage Status
Change from base Build d3a6cd1651e9720fbd883cfa44d78906586213ad: 0.0%
Covered Lines: 2544
Relevant Lines: 3297
💛 - Coveralls

@sffc sffc merged commit b100859 into master Oct 6, 2020
@sffc sffc deleted the fixeddecimal-bounds branch October 6, 2020 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbraniecki zbraniecki zbraniecki approved these changes

@filmil filmil Awaiting requested review from filmil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix out-of-bounds when converting from FixedDecimal to PluralOperands
3 participants
@sffc @coveralls @zbraniecki