-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add subset of dates data to DataProvider #256
Conversation
Pull Request Test Coverage Report for Build d5278718a395b54b2e37b937155eae457a452eb4-PR-256
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This is definitely on the right track. Left some comments.
Thanks for the review! I filed #257 to discuss how should request/response look like for |
740fbc2
to
09d1c66
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
09d1c66
to
42aeb89
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
42aeb89
to
c31c124
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
I updated the PR to reflect Shane's initial comments. I have two follow up PRs that I'd like to start getting ready to land, but cycling 4 PRs in git is a mess (Mercurial solved it years ago so well!). Shane, how far do you think this is from being landable? |
You are using It makes no sense to me to have I would like to either:
|
@sffc I removed the options, and we can revisit the splits later. |
a9dc90e
to
6d85f62
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I'm approving but I still have questions/comments/suggestions.
6d85f62
to
c217162
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
c217162
to
4353ef3
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We should have a real Default implementation for the date symbols, but we can do that later:
This PR introduces a subset of ca-gregorian from cldr-dates that will be needed for initial
DateTimeFormat
.See: https://github.com/unicode-cldr/cldr-dates-modern/blob/master/main/en/ca-gregorian.json
The PR operates on
Cow
everywhere, but once we landDateTime
we may want to switch some of them toPattern
structs if we measure performance wins with no significant payload growth.