Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor from for loop append to extend #2531

Merged
merged 2 commits into from
Sep 8, 2022
Merged

Refactor from for loop append to extend #2531

merged 2 commits into from
Sep 8, 2022

Conversation

kelebra
Copy link
Contributor

@kelebra kelebra commented Sep 8, 2022 •
edited
Loading

As per #2482 I refactored 2 places in normalizer from

for {
  vector.push(...)
}

to vector.extend(...) following suggestion in the issue description

hsivonen
hsivonen approved these changes Sep 8, 2022
View reviewed changes
Copy link
Member

@hsivonen hsivonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@hsivonen hsivonen merged commit 90235ae into unicode-org:main Sep 8, 2022
@sffc sffc mentioned this pull request Sep 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsivonen hsivonen hsivonen approved these changes

@echeran echeran Awaiting requested review from echeran echeran is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kelebra @hsivonen