Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create DateTimeParser in experimental branch ixdtf #2480

Merged
merged 6 commits into from
Oct 7, 2022
Merged

Create DateTimeParser in experimental branch ixdtf #2480

merged 6 commits into from
Oct 7, 2022

Conversation

samchen61661
Copy link
Member

Create DateTimeParser in experimental branch ixdtf (#2127)

@samchen61661 samchen61661 requested a review from a team as a code owner August 30, 2022 07:14
@CLAassistant
Copy link

CLAassistant commented Aug 30, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@samchen61661 samchen61661 marked this pull request as draft August 30, 2022 07:15
@samchen61661 samchen61661 requested review from sffc, Manishearth and nordzilla and removed request for a team August 30, 2022 07:15
sffc
sffc reviewed Aug 30, 2022
View reviewed changes
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Praise: The general shape of this solution looks good. I haven't reviewed the exact parsing logic line-by-line.

experimental/ixdtf/src/parser.rs Outdated
}

impl DateTimeSeparator {
fn value(&self) -> String {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: return &'static str instead of String to avoid the extra allocation.

In general, the parser should require no allocations. You can achieve this by making your crate #![no_std] and not enabling the "alloc" feature (or making it optional).

Manishearth
Manishearth reviewed Aug 30, 2022
View reviewed changes
@samchen61661 samchen61661 marked this pull request as ready for review September 16, 2022 23:37
@Manishearth Manishearth removed their request for review September 19, 2022 23:09
sffc
sffc reviewed Sep 19, 2022
View reviewed changes
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Praise: Much better error handling than the first version. I think this is basically ready to land in experimental. This is a good base we can build from.

@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • experimental/ixdtf/README.md is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

sffc
sffc approved these changes Oct 7, 2022
View reviewed changes
@samchen61661 samchen61661 merged commit 4f7e7de into unicode-org:main Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sffc sffc sffc approved these changes

@nordzilla nordzilla Awaiting requested review from nordzilla

@Manishearth Manishearth Awaiting requested review from Manishearth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samchen61661 @CLAassistant @sffc @Manishearth