Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature use suggestions added to the style guide #247

Merged
merged 1 commit into from
Sep 24, 2020

Conversation

filmil
Copy link
Contributor

@filmil filmil commented Sep 17, 2020

Adds specific instructions about hiding new dependencies or debug code
behind new features.

Closes #219

@filmil filmil requested a review from a team as a code owner September 17, 2020 16:30
@filmil filmil requested a review from sffc September 17, 2020 16:30
@coveralls
Copy link

coveralls commented Sep 17, 2020

Pull Request Test Coverage Report for Build b8c6393f488f1324590a73b7aa68b3ee090cc378-PR-247

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.951%

Totals Coverage Status
Change from base Build 7cc838c31053e52d660c690be850bfdfbe899cb0: 0.0%
Covered Lines: 2153
Relevant Lines: 2727

💛 - Coveralls

zbraniecki
zbraniecki previously approved these changes Sep 17, 2020
Adds specific instructions about hiding new dependencies or debug code
behind new features.

Closes unicode-org#219
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • docs/style-guide.md is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@sffc sffc added waiting-on-author PRs waiting for action from the author for >7 days and removed waiting-on-author PRs waiting for action from the author for >7 days labels Sep 20, 2020
@filmil filmil merged commit f49fdbe into unicode-org:master Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style guide: When to use crate features?
5 participants