Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding example for FixedDecimal #246

Merged
merged 1 commit into from
Sep 18, 2020
Merged

Adding example for FixedDecimal #246

merged 1 commit into from
Sep 18, 2020

Conversation

sffc
Copy link
Member

@sffc sffc commented Sep 17, 2020

First PR on #187

@sffc sffc requested a review from zbraniecki September 17, 2020 07:56
@sffc sffc requested a review from a team as a code owner September 17, 2020 07:56
sffc
sffc commented Sep 17, 2020
View reviewed changes
components/num-util/examples/permyriad.rs
@@ -0,0 +1,13 @@
// In computers, monetary values are sometimes stored as integers representing one ten-thousandth
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this comment be RustDoc? Do the examples show up on docs.rs?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 820168d7a1fa49c0a32276e52ad294da439a9b1b-PR-246

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.951%
Totals Coverage Status
Change from base Build 7cc838c31053e52d660c690be850bfdfbe899cb0: 0.0%
Covered Lines: 2153
Relevant Lines: 2727
💛 - Coveralls

@sffc sffc requested a review from echeran September 17, 2020 17:26
@sffc sffc merged commit d673476 into unicode-org:master Sep 18, 2020
@sffc sffc deleted the examples branch September 18, 2020 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbraniecki zbraniecki zbraniecki approved these changes

@echeran echeran Awaiting requested review from echeran

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sffc @coveralls @zbraniecki