Create a new type MinutesSinceEpoch to replace i32 in MetaZonePeriodV1 #2355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samchen61661
requested review from
sffc and
nordzilla
and removed request for
a team
samchen61661
commented
Aug 8, 2022
|
|
||
| pub(crate) struct DeserializeMinutesSinceEpochString; | ||
|
|
||
| impl<'de> serde::de::Visitor<'de> for DeserializeMinutesSinceEpochString { |
There was a problem hiding this comment.
there are some errors complaining like failed to resolve: use of undeclared crate or module de`` or cannot find Deserialize.
I tried to use sth like use ::serde::{de, Deserialize, Deserializer}; from other examples, but had no luck.
There was a problem hiding this comment.
Add the annotation #[cfg(feature = "serde")]
samchen61661
commented
Aug 8, 2022
| where | ||
| S: serde::Serializer, | ||
| { | ||
| let string = DateTime::from_minutes_since_local_unix_epoch(26382240)?.to_string(); |
There was a problem hiding this comment.
looks like there is no to_string for DateTime. Should I construct the string by myself here?
|
We are now considering this blocked on #2127 |
sffc
reviewed
Aug 10, 2022
robertbastian
added
the
blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new type like MinutesSinceEpoch to replace i32 in MetaZonePeriodV1 (#2155)