-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate data structs to icu_pattern in 2.0 #5256
Comments
|
Nested writeables can usually be composed in such a way that it should be equivalent to a loop when unrolled, but I agree it can be tricky to get to that point. The list data struct could apply the additional invariants during deserialization. The main thing we want for 2.0 though is to evaluate the cases and make an educated engineering decision that certain things are too much work / infeasible / lacking in ROI. I'm okay making such a determination for ListFormatter data. |
Then I'm basically writing a new pattern type. As I already have a pattern type I don't see what the upside would be. |
Closing this because all work is tracked elsewhere |
Now that we have
icu_pattern
, we should migrate more components to use it where possible. Candidates:icu_decimal
(related: Reduce stack size of DecimalSymbolsV1 #4437)icu_list
icu_experimental
that hasn't been migrated yet (not a 2.0 blocker)icu_datetime
but that will require more surgery and might not be worth itCC @robertbastian
The text was updated successfully, but these errors were encountered: