Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatagenDriver::export should return a results bag #4716

Open
sffc opened this issue Mar 20, 2024 · 1 comment
Open

DatagenDriver::export should return a results bag #4716

sffc opened this issue Mar 20, 2024 · 1 comment
Labels
C-data-infra Component: provider, datagen, fallback, adapters S-medium Size: Less than a week (larger bug fix or enhancement)

Comments

@sffc
Copy link
Member

sffc commented Mar 20, 2024

Currently the function prints a bunch of stuff to the console and returns (). It should return an object with information about the job that completed (still logging the text for CLI users). For example:

  1. Resolved options for DeduplicationStrategy
  2. Information about the locales that were included or which failed to include. Might need to be per-key.
  3. Exporter-specific stats like how many bytes were written (requires adding an associated type to DataExporter)

What needs to be done in 2.0:

  1. Changing the signature of the .export function
  2. Adding the associated type to DataExporter

What could be done sooner:

  1. Make a new .export_with_results function
  2. Resolved options and locale inclusion info

CC @robertbastian @zbraniecki

@sffc sffc added C-data-infra Component: provider, datagen, fallback, adapters S-medium Size: Less than a week (larger bug fix or enhancement) 2.0-breaking Changes that are breaking API changes labels Mar 20, 2024
@sffc sffc added this to the ICU4X 2.0 milestone Mar 20, 2024
@sffc sffc added this to icu4x 2.0 Mar 20, 2024
@sffc sffc moved this to Unclaimed for sprint in icu4x 2.0 Mar 20, 2024
@robertbastian
Copy link
Member

I've done this without associated types for now, because we use dyn DataExporter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-data-infra Component: provider, datagen, fallback, adapters S-medium Size: Less than a week (larger bug fix or enhancement)
Projects
None yet
Development

No branches or pull requests

2 participants