-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking change in icu_provider 1.2.0 #3332
Comments
Was noted in a review in #3324 (comment); the API in question was |
This is interesting. Maybe we should just be importing the crates directly? Since Also, even when using the |
You can check here the build errors we're getting after importing |
Oof, it looks like we lost a
Since you guys have a lot of call sites, we should add "test with Boa" to our release checklist... |
Regarding the exports of |
This PR upgrades ICU to 1.2. Unfortunately we still have some breaking changes, so this is being handled in unicode-org/icu4x#3332 Co-authored-by: jedel1043 <[email protected]>
With the update from icu_provider 1.1.0 to 1.2.0, the
pub use prelude::*
has been removed:https://docs.rs/icu_provider/1.1.0/src/icu_provider/lib.rs.html#199
This means that after a
cargo update
, we can no longer use the following syntax:This is a semver-incompatible change, unfortunately :(
The text was updated successfully, but these errors were encountered: