Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22781 Add test for portion format with parts per billion (C++) #3389

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

younies
Copy link
Member

@younies younies commented Feb 11, 2025

Description:

  • Added a new test method TestPortionFormat() in numbertest_api.cpp
  • Updated numbertest.h to declare the new test method
  • Test covers formatting of "portion-per-1e9" unit in different locales
  • Includes test cases for singular and plural forms
  • Handles known issue for other portion units with a log message

java code : #3390

Checklist

  • Required: Issue filed: ICU-22781
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@younies younies force-pushed the cpp-test-format-portion branch from 8d6c193 to 4ea4a56 Compare February 11, 2025 14:05
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

Copy link
Contributor

@richgillam richgillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test case looks good, but you might want to put comments on something on all the UNKNOWN things that are covered by the logKnownIssue() in the code.

{"portion-per-1e5", "en-US", 1, "UNKNOWN"},
{"portion-per-1e6", "en-US", 1, "UNKNOWN"},
{"portion-per-1e7", "en-US", 1, "UNKNOWN"},
{"portion-per-1e8", "en-US", 1, "UNKNOWN"},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these UNKNOWN things are being caught by the logKnownIssue() below, right? You should probably put comments on the test cases themselves indicating this too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, all of them are being caught by logKnownIssue,

Okay, I will add a comment in a following PR.

@younies younies merged commit 42e3b43 into unicode-org:main Feb 11, 2025
94 checks passed
@younies younies deleted the cpp-test-format-portion branch February 11, 2025 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants