-
-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ICU-21581 ICU Change Reports for 70rc #1877
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update icu4j/build.properties to - api.doc.version = 70.1, maven.pom.ver = 70.1, icu4j/main/shared/build/common.properties - icu4j.impl.version = 70.1, then regenerate?
3ea7762
to
eda16bc
Compare
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
The PR title and the commit message no longer reflect the changes (no longer just ICU4J). Changing the commit title is easiest when you update the reports anyway, using |
FYI: The PR description had problems; I just fixed them:
|
0aceab1
to
0469797
Compare
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
Craig regenerated after the version numbers were updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sven-oly, thanks for updating after the version change, and for fixing the override problem.
However, we have another problem like this: @roubert changed many operator== and operator!= from returning UBool to returning bool. Now these are also cluttering up the C++ API change report, which makes it hard to see real API changes.
@srl295 et al., how about we also ignore UBool->bool changes? In StableAPI.java I think that should work with
"\\bUBool\\b", "bool",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise lgtm AFAICT...
0469797
to
4fdffab
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm tnx!
4fdffab
to
7ac1b2f
Compare
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still lgtm
Checklist