Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-21581 ICU Change Reports for 70rc #1877

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

sven-oly
Copy link
Contributor

@sven-oly sven-oly commented Sep 22, 2021

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-21581
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

Copy link
Member

@yumaoka yumaoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update icu4j/build.properties to - api.doc.version = 70.1, maven.pom.ver = 70.1, icu4j/main/shared/build/common.properties - icu4j.impl.version = 70.1, then regenerate?

icu4j/APIChangeReport.html Outdated Show resolved Hide resolved
sven-oly added a commit to sven-oly/icu that referenced this pull request Sep 23, 2021
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@markusicu
Copy link
Member

The PR title and the commit message no longer reflect the changes (no longer just ICU4J).
Please change both to “ICU-21581 API change reports for ICU 70rc”.

Changing the commit title is easiest when you update the reports anyway, using git commit -a --amend (without -m) which lets you change the commit message.

@markusicu
Copy link
Member

FYI: The PR description had problems; I just fixed them:

  • The “Required: Issue filed:” was missing the ICU ticket number
  • All of the checkboxes were ticked although not all of those things are done (nor need to be done). I unchecked the ones that aren't done.

icu4c/APIChangeReport.md Outdated Show resolved Hide resolved
@sven-oly sven-oly changed the title ICU-21581 Add ICU4J Change Report for release candidate ICU-21581 Add ICU4J and ICU4C Change Reports for release candidate Sep 29, 2021
@sven-oly sven-oly changed the title ICU-21581 Add ICU4J and ICU4C Change Reports for release candidate ICU-21581 ICU Change Reports for 70rc Sep 29, 2021
sven-oly added a commit to sven-oly/icu that referenced this pull request Sep 29, 2021
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@markusicu markusicu dismissed yumaoka’s stale review September 29, 2021 16:25

Craig regenerated after the version numbers were updated.

Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sven-oly, thanks for updating after the version change, and for fixing the override problem.

However, we have another problem like this: @roubert changed many operator== and operator!= from returning UBool to returning bool. Now these are also cluttering up the C++ API change report, which makes it hard to see real API changes.

@srl295 et al., how about we also ignore UBool->bool changes? In StableAPI.java I think that should work with

    "\\bUBool\\b", "bool",

Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm AFAICT...

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/APIChangeReport.html is different
  • icu4c/APIChangeReport.md is different
  • tools/release/java/src/main/java/com/ibm/icu/dev/tools/docs/StableAPI.java is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

markusicu
markusicu previously approved these changes Sep 29, 2021
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm tnx!

@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still lgtm

@sven-oly sven-oly closed this Sep 29, 2021
@sven-oly sven-oly reopened this Sep 29, 2021
@sven-oly sven-oly merged commit 60c1857 into unicode-org:main Sep 29, 2021
@sven-oly sven-oly deleted the BRS70_API_status branch March 11, 2022 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants