Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLDR-13730 add grammaticalFeatures #830

Merged
merged 1 commit into from
Nov 9, 2020
Merged

CLDR-13730 add grammaticalFeatures #830

merged 1 commit into from
Nov 9, 2020

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Nov 5, 2020

CLDR-13730

  • also general cleanup
  • moved grammaticalGender to separate file
  • corrected duplicate locale fil in common/supplemental/grammaticalFeatures.xml

@srl295
CLDR-13730 JSON for grammaticalFeatures
d322fc5 
- also general cleanup
- moved grammaticalGender to separate file
- corrected duplicate locale fil in common/supplemental/grammaticalFeatures.xml
@srl295 srl295 self-assigned this Nov 5, 2020
@srl295
Copy link
Member Author

srl295 commented Nov 5, 2020

Want to review the JSON format? See https://gist.github.com/srl295/2c521b0cc01d904beea439df93b51454

@srl295
Copy link
Member Author

srl295 commented Nov 5, 2020

Notes:

  1. I split out grammaticalGenderFeatures.json for some data, because the current converter is a stream based approach and isn't easily able to backup and interleave data without special purpose code (such as was done for unit preferences CLDR-13730 json: support unit preferences #820 ). This isn't ideal, and we may want to restructure the converter to make it easier to produce better output.

  2. there was a case where the 'no grammatical features' entry had fil listed twice. I have the converter ignore the second fil, but when there are unit tests for this feature, it would be good to check for this situation.

@srl295 srl295 mentioned this pull request Nov 6, 2020
Merged
sffc
sffc approved these changes Nov 9, 2020
View reviewed changes
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks plausible.

@srl295 srl295 merged commit 9a67749 into unicode-org:master Nov 9, 2020
@srl295 srl295 deleted the gramm13730 branch November 9, 2020 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sffc sffc sffc approved these changes

@macchiati macchiati Awaiting requested review from macchiati

@echeran echeran Awaiting requested review from echeran

@JCEmmons JCEmmons Awaiting requested review from JCEmmons

Assignees

@srl295 srl295

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srl295 @sffc