Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ch33421] Sync realms from etools #1902

Merged
merged 8 commits into from
Apr 25, 2023
Merged

[ch33421] Sync realms from etools #1902

merged 8 commits into from
Apr 25, 2023

Conversation

roman-karpovich
Copy link
Contributor

[ch33421]

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #33421: Synchronize realms for external users between eTools and PRP.

@roman-karpovich roman-karpovich changed the base branch from develop to 32258-introduce-realms April 6, 2023 04:42
@roman-karpovich roman-karpovich requested a review from emaciupe April 7, 2023 05:39
@roman-karpovich roman-karpovich added Ready and removed wip labels Apr 7, 2023
emaciupe
emaciupe requested changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@emaciupe emaciupe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sync updates: the user also needs to be created if it doesn't exist. Besides email, you'll need also first, middle and last name to be in the payload as well and instead of get_obj_or_404 please do a get _or _create - also please pull from 32258-introduce-realms-tests - and you should have all the tests pass

@roman-karpovich roman-karpovich changed the base branch from 32258-introduce-realms to 32258-introduce-realms-tests April 13, 2023 05:56
@roman-karpovich
Copy link
Contributor Author

Sync updates: the user also needs to be created if it doesn't exist. Besides email, you'll need also first, middle and last name to be in the payload as well and instead of get_obj_or_404 please do a get _or _create - also please pull from 32258-introduce-realms-tests - and you should have all the tests pass

updated

emaciupe
emaciupe approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@emaciupe emaciupe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@robertavram robertavram merged commit ba10f71 into 32258-introduce-realms-tests Apr 25, 2023
@robertavram robertavram deleted the ch33421-sync-realms-from-etools branch April 25, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emaciupe emaciupe emaciupe approved these changes

Assignees
No one assigned
Labels
Ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roman-karpovich @emaciupe @robertavram