[ch29016] Added custom json Validator based on jsonschema lib #1744
Conversation
|
This pull request has been linked to Shortcut Story #29016: Indicator Data Validator. |
emaciupe
force-pushed
the
29016-indicator-data-validator
branch
from
d536eaf to
247a6a2
Compare
|
@domdinicola i didn't mark it as ready, please take a look and give an earlier input from your side on the approach. Thanks! |
|
@emaciupe looks good to me! what else is missing here? |
|
|
||
| class AddIndicatorObjectTypeValidator: | ||
|
|
||
| def __call__(self, value): | ||
| from etools_prp.apps.cluster.models import ClusterActivity, ClusterObjective |
There was a problem hiding this comment.
why have these been moved?
There was a problem hiding this comment.
@domdinicola Because circular import happened
There was a problem hiding this comment.
weird.... code changes should not have impacted that...
@domdinicola test changes were committed, so i'd say nothing left out from this PR now. There's another separate card to clean up the indicator data. |
|
yep... we should write a script to clean the values and/or flag the results that need to be fixed manually |
|
@emaciupe we should do this also in eTools, but let's check it with @robertavram first |
emaciupe
changed the title
[ch29016]